-
-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent setting an empty column name #5742
Prevent setting an empty column name #5742
Conversation
Also, to solve @tomtomme 's issue all you really need to do is call "delete column" properly if someone erases the name. Because that was the original intended behaviour right? |
I would consider this dangerous behaviour IF the undo button does not work. Because it is not intuitive that deleting the name would delete also my data. Deleting the name is something a user most probably would do by accident. So the best intended behaviour from my point of view, would be, to restore the original name OR just do nothing. |
Indeed, this is what I mean by "make sure it just calls deleteColumn" cause that would include the undo/redo |
But I also disagree that making the name empty should remove the column: most of the time, making the name empty will be just a bad manip of the user. Trying to make it empty should reset the old name. |
Ok wahtever but Im fairly sure you @boutinb are the one who added this functionality in the first place. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
7f4091e
to
268b031
Compare
Fixes https://github.com/jasp-stats/jasp-test-release/issues/2808