Computed Columns should write to only filtered rows #5709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…omputed column fixes jasp-stats/jasp-issues#2972 ([Bug]: PC scores added on wrong row if data have pass-through filters)
boutinb
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes jasp-stats/jasp-issues#2972 (Bug: PC scores added on wrong row if data have pass-through filters)
What it does do is make sure that when the column (over)write functions get precisely the amount of filtered rows it fills the empty ones in with "". This way when an analysis writes it will write to the same rows it got the data from.
Doesnt yet take filters for user-added computed columns into account, Id prefer to add a proper interface for it.
And then immediately add support for multiple filters.