Remote cellar Mac #5686
Merged
Remote cellar Mac #5686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vandenman
reviewed
Oct 8, 2024
| @@ -0,0 +1,93 @@ | |||
| #!/usr/bin/env python3 | |||
There was a problem hiding this comment.
so I get this was perhaps easier to write, but this could also just be an R script that uses libarchive? jaspTools already uses an R interface to libarchive, for example.
There was a problem hiding this comment.
What would be the advantage?
There was a problem hiding this comment.
Then python doesnt become a builddep, although given that buildbot already runs its hardly a problem
JorisGoosen
reviewed
Oct 8, 2024
| #this handles the cellar download. | ||
| if(R_PKG_CELLAR_DOWNLOAD_REMOTE AND R_PKG_CELLAR_PATH STREQUAL "${CMAKE_SOURCE_DIR}/cellar/" AND NOT EXISTS "${CMAKE_SOURCE_DIR}/cellar/") | ||
| #set appropriate default remote if needed | ||
| if(R_PKG_CELLAR_REMOTE STREQUAL "") |
There was a problem hiding this comment.
So yeah, would be nice at a later stage if there is some more IDing of the the cellar downloads.
Something with hashes or so.
JorisGoosen
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Notes: not yet active on Windows
I disabled it on windows for now because strange things still happen there.
But this way we can get around blavaan issue on mac.
See the cellars here
https://static.jasp-stats.org/development/cellars/