-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Node-ification #25
Open
jasonjgardner
wants to merge
18
commits into
jasonjgardner:feat/node
Choose a base branch
from
Offroaders123:main
base: feat/node
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Aug 27, 2024
-
Type Checking, Initial Node Test
Tried to run `tsc -w`, but it didn't work because it couldn't resolve `@hono/hono/jsx`, changing it to `@jsr/hono__hono/jsx` makes it work now. microsoft/TypeScript#58600 I'm going to see what it looks like on making this project work closer to plain ESM/Node/npm, maybe with the intent of getting it to work in frontend JS too, I'm not sure it's setup for that just yet.
Configuration menu - View commit details
-
Copy full SHA for 1cc2ccd - Browse repository at this point
Copy the full SHA 1cc2ccdView commit details -
Going to abstract out the library parts of the code, and allow it to work anywhere, without npm, jsr, Bun, Node, or anything like that. Just plain dependencies :)
Configuration menu - View commit details
-
Copy full SHA for 24d989d - Browse repository at this point
Copy the full SHA 24d989dView commit details -
This really helps with tightening up parts of a codebase, it took me a while to get on board with it, but it really is great!
Configuration menu - View commit details
-
Copy full SHA for 654b6e9 - Browse repository at this point
Copy the full SHA 654b6e9View commit details -
Configuration menu - View commit details
-
Copy full SHA for d36d5da - Browse repository at this point
Copy the full SHA d36d5daView commit details -
Going to migrate the code over to Node from the backend of it first, then look into the CLI parts again down the road. Didn't know about Node's `parseArgs()` feature, that's awesome! Pretty much exactly what I've been wanting for NBTify 🔥 I don't want to make a crazy complex CLI setup for that, it should be possible with just some regular modules and logging. I'll probably sway my mind on that later on, but yeah hehe.
Configuration menu - View commit details
-
Copy full SHA for ce0b4be - Browse repository at this point
Copy the full SHA ce0b4beView commit details -
I think the goal is that I'm curious if this will work in the frontend, and in all environments, without needing an opinionated setup for it.
Configuration menu - View commit details
-
Copy full SHA for 7c63609 - Browse repository at this point
Copy the full SHA 7c63609View commit details -
Going back to the basics now (this is definitely opinionated, I like having a whole universal stack whenever possible)
Configuration menu - View commit details
-
Copy full SHA for fb12672 - Browse repository at this point
Copy the full SHA fb12672View commit details -
Remaining parts from the last step, and parts of the Deno config I realized that the `package.json` could have instead.
Configuration menu - View commit details
-
Copy full SHA for da9bea8 - Browse repository at this point
Copy the full SHA da9bea8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2499acd - Browse repository at this point
Copy the full SHA 2499acdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7f2b029 - Browse repository at this point
Copy the full SHA 7f2b029View commit details -
Configuration menu - View commit details
-
Copy full SHA for bee2876 - Browse repository at this point
Copy the full SHA bee2876View commit details -
Configuration menu - View commit details
-
Copy full SHA for 054fcfc - Browse repository at this point
Copy the full SHA 054fcfcView commit details -
Strict NodeNext + Pretty Config
The linting for the tsconfig was mad at the lowercase 'asynciterable' lib option for some reason. This helps make things even easier to run as plain ESM in the browser, nearly there!
Configuration menu - View commit details
-
Copy full SHA for 0a12519 - Browse repository at this point
Copy the full SHA 0a12519View commit details -
They are more specific primitives to what the underlying NBT uses, this will make things more safe when loading the file. I still have to bring this to the rest of the functions that implement around these types. Borrowed this from my Structure-Reader project! https://github.com/Offroaders123/Structure-Reader `block_position_data` still needs specific NBTify typings, I didn't have those in my reference code.
Configuration menu - View commit details
-
Copy full SHA for 34859dd - Browse repository at this point
Copy the full SHA 34859ddView commit details
Commits on Aug 31, 2024
-
Started working on adding the proper typings for things with the new edits to `types.ts`, and accessing things with the namespace gets a bit taxing, so I want to migrate to this setup before implementing that. Definitely going to look into using better-named named exports for NBTify, they don't have to be so general as I have them now.
Configuration menu - View commit details
-
Copy full SHA for a2a1957 - Browse repository at this point
Copy the full SHA a2a1957View commit details -
Started working on this the other day, now I think this version is the most structurally-sound (pun unintended) Been using this Gist for documentation :) https://gist.github.com/tryashtar/87ad9654305e5df686acab05cc4b6205 The thing I noticed here was that NBT-specific primitives weren't being used for Int number types, and that means that they just get saved as Double values, which might not get handled correctly by the game.
Configuration menu - View commit details
-
Copy full SHA for a36ecfb - Browse repository at this point
Copy the full SHA a36ecfbView commit details -
I don't think this is doing any kind of additional transform to the underlying object, so it can just be passed to the `write()` function itself :)
Configuration menu - View commit details
-
Copy full SHA for 0e298b1 - Browse repository at this point
Copy the full SHA 0e298b1View commit details -
This option was renamed a few versions ago, so it may have used to work previously. My bad it wasn't noted much!
Configuration menu - View commit details
-
Copy full SHA for 1d47037 - Browse repository at this point
Copy the full SHA 1d47037View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.