-
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
chore: repo cleanup and contributing doc
- Loading branch information
1 parent
23eed6f
commit aa06c1b
Showing
6 changed files
with
93 additions
and
23 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,67 @@ | ||
# Contribution Guidelines | ||
|
||
Hello! Thanks for your interest in contributing to this project. | ||
Outlined below are the expected guidelines for contributing. Please read | ||
them carefully! | ||
|
||
**Note**: This document does not cover things that would belong in a | ||
code of conduct document. | ||
|
||
## Table of Contents | ||
|
||
<!-- !!! Generated !!! --> | ||
<!-- toc --> | ||
- [Contributing Code](#contributing-code) | ||
- [Commit Format](#commit-format) | ||
- [Pull Request Format](#pull-request-format) | ||
- [Code Size](#code-size) | ||
- [Code Style](#code-style) | ||
<!-- /toc --> | ||
|
||
## Contributing Code | ||
|
||
Code contributions should follow the Github Pull Request model for all | ||
changes, even for contributors with commit access. This means that you | ||
should create a branch in a repo (even if it's your own fork) and create | ||
a pull request from that branch into the main repo. | ||
|
||
### Commit Format | ||
|
||
Commits should follow the Conventional Commit format[^1]. However, | ||
this is only a strong requirement for the Pull Request title and body, | ||
because we **squash** commits on merge. | ||
|
||
### Pull Request Format | ||
|
||
We do not provide templates for pull requests because of our nature of | ||
squash and merging using the PR body. As template would muddy each | ||
commit's body. So, feel free to use whatever format you'd like, but we'd | ||
like the following: | ||
|
||
- A clear and concise title following conventional commit format[^1] | ||
- A body that clearly explains the 5 W's of the change: | ||
- **What** is the change? | ||
- **Why** is the change necessary? | ||
- **When** should the change be merged? | ||
- **Who** is the change for? | ||
- **Where** does the change apply? | ||
- **This does not need to be a form! Just approach your wording from | ||
these questions.** | ||
- (Optional, but recommended): 72 character line wrap for the title and | ||
body. (This is a soft limit, not a hard one.) | ||
|
||
### Code Size | ||
|
||
Please keep pull requests small and focused. If you have a large change | ||
that you'd like to make, likely create an issue to discuss it first but | ||
at the very least, think about how to break it apart into multiple | ||
distinct changes. We're here to help you do that! | ||
|
||
### Code Style | ||
|
||
All code should be formatted and match the style of code around it. | ||
While we don't have a strong code style guide, we do have automatic | ||
formatters and linters. These can be run with `mise run fmt` and `mise | ||
run lint` respectively. | ||
|
||
[^1]: [Conventional Commit](https://www.conventionalcommits.org/en/v1.0.0) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
#!/usr/bin/env bash | ||
# Updates all markdown files in the repository with the latest table of | ||
# contents based on their contents. | ||
|
||
# TOOL_VERSION is the version of the mdtoc tool to use. | ||
TOOL_VERSION=v1.3.0 | ||
|
||
exec find . -name '*.md' -exec go run sigs.k8s.io/mdtoc@"$TOOL_VERSION" --inplace --max-depth=5 {} + -print |