Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: ReplacerProcessorTestの分割、Replacer複合テストの追加 #187

Merged
merged 6 commits into from
Jul 19, 2024
Merged

test: ReplacerProcessorTestの分割、Replacer複合テストの追加 #187

merged 6 commits into from
Jul 19, 2024

Conversation

book000
Copy link
Member

@book000 book000 commented Jul 14, 2024

分割にあわせ、以下の複合テストを追加。

  • If there is an alias for a server emoji, the EmojiReplacer should be applied.
  • If there is no alias for a server emoji, the GuildEmojiReplacer should be applied.
  • User mentions cannot be replaced by aliases.
  • After the URL is replaced, the alias should be applied.

@book000 book000 requested a review from yuuahp July 14, 2024 17:15
@yuuahp yuuahp enabled auto-merge July 19, 2024 09:59
@book000
Copy link
Member Author

book000 commented Jul 19, 2024 •
edited
Loading

approveしてないからblockingされてるくない？

@yuuahp
Copy link
Member

yuuahp commented Jul 19, 2024

あっ

@yuuahp yuuahp added this pull request to the merge queue Jul 19, 2024
Merged via the queue into jaoafa:main with commit 8d4a1f5 Jul 19, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuuahp yuuahp yuuahp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replacersの複合テスト
2 participants
@book000 @yuuahp