This repository has been archived by the owner on May 17, 2023. It is now read-only.
Chart, background and formula change #36
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should make even less likely for beginners to accidentally edit the backup version and lose all changes.
The formula that gets written for the first 6 days is wrong (avgStart is negative). This change makes sure there is a legal formula for the first few days and should make life easier for new users.
This change adds a line chart to the almanac email that contains the daily goal, the written words, and the 7-day average.
|
@Jerome81, I like the chart. It is similar to the dashboard I have created for my writing stats (I keep meaning to post the code for it), but conveniently contained in the email message. I do have a suggestion, however: Could you add a setting to the spreadsheet, something like: "Include chart in email?" If the setting is true, include the chart, if it is false, don't include it. That way a user can decide for themselves if they want it, and change their preference at any time. |
The chart is included only if there is the following setting in the config tab: Include Chart in Almanac | 1 | Set | Include a chart that contains the goal, total and 7-day average in the daily email For backward compatibility, I added a method that takes a default value for the config and doesn't stop execution if it can't find the value in the spreadsheet. This value defaults to 0, so if a user copies this new version, he shouldn't see any change in behavior.
|
@jamietr1 Sure, no problem. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a line chart to the daily almanac containing the daily goal, words written and 7-day avg.
Makes the formula correct for the first 6 days.
Sets the background to gray for the backup copy.