Remove the need for a timeout in smoke test for font loading #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wired up the font loading events to PhantomJS.
onInitialized
is called before the page is loaded (especially before the IIFE with the TypeKit boilerplate is executed).fontactive
anddone
in the browser's global namespace. The loaded fonts get stored in a local array. Whendone
is called PhantomJS is notified viacallPhantom
(which is provided by PhantomJS).callPhantom
triggerspage.onCallback
with the collected fonts array as argument (Note: only serializable data can be exchanged this way).Remaining problems
phantom.exit()
is now withinonCallback
which is less than ideal. Either should there be a mechanism for collecting asynchronous test results or each test should go into its own file. The former is probably better for performance (because of spawning less processes) while the latter is generally simpler and makes it easier to organize the tests.