Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
I took a stab at #41 here. What's missing is a
bbqueue::heap::FramedProducer
andbbqueue::heap::FramedConsumer
. Also I'm unsure of how you want to structure the crate in terms of heap vs globally-allocated/stack-allocated.For heap-allocated framed producer/consumer, here's what I'm thinking:
framed::FramedProducer
andframed::FramedConsumer
intocommon
, make them usecommon::Producer
/common::Consumer
instead ofbbqueue::Producer
/bbqueue::Consumer
.bbqueue::FramedProducer
/bbqueue::FramedConsumer
with lifetimes re-added.heap::FramedProducer
/heap::FramedConsumer
with reference counter for dropping (duplicateheap::Producer
/heap::Consumer
dropping code.If you like that plan I can go ahead an implement it.
I split the common code into a separate
common
module that hasProducer<N>
andConsumer<N>
types without lifetimes. Thebbbuffer
module exports wrappedProducer<'a, N>
andConsumer<'a, N>
types with the lifetimes. Theheap
module exports wrappedProducer<N>
andConsumer<N>
types that include a reference counter to determine if the underlyingConstBBBuffer
should be dropped when the producer/consumer is dropped.