Skip to content

Commit

Permalink
Update CHANGELOG.md, Update symbol director reference
Browse files Browse the repository at this point in the history
  • Loading branch information
jameskr97 committed Sep 19, 2021
1 parent 7cd5f1d commit b1667bd
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 3 deletions.
7 changes: 7 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,13 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

## [0.2.0.3] - 2021-09-19
### Fixed
- Flush symbol after stored in database to get "symbol_location" from project

### Changed
- Symbol "doesn't exist", and "already uploaded" log messages

## [0.2.0.2] - 2021-09-18
### Added
- More log messages on minidump processing
Expand Down
4 changes: 2 additions & 2 deletions crashserver/webapp/models/symbol.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
from sqlalchemy.sql import func, text
from flask import current_app

from crashserver.config import settings
from crashserver import config
from crashserver.webapp import db


Expand Down Expand Up @@ -36,7 +36,7 @@ class Symbol(db.Model):
def store_file(self, file_content: bytes):
filesystem_module_id = self.build.module_id.split(".")[0]
dir_location = Path(self.build.module_id, self.build.build_id, filesystem_module_id + ".sym")
sym_loc = self.project.symbol_location / dir_location
sym_loc = config.get_appdata_directory("symbol") / str(self.project_id) / dir_location
sym_loc.parent.mkdir(parents=True, exist_ok=True)

with open(sym_loc.absolute(), "wb") as f:
Expand Down
1 change: 0 additions & 1 deletion crashserver/webapp/operations.py
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ def symbol_upload(session, project_id: str, symbol_file: bytes, symbol_data: Sym
arch=symbol_data.arch,
app_version=symbol_data.app_version,
)
session.flush()
build.symbol.store_file(symbol_file)
session.commit()

Expand Down

0 comments on commit b1667bd

Please sign in to comment.