Skip to content

Commit

Permalink
tests: temporarily exclude gdrivefs from extras (#5483)
Browse files Browse the repository at this point in the history
When trying to publish to pypi, we get:

```
Invalid value for requires_dist. Error: Can't have direct dependency:
"gdrivefs @ git+https://github.com/intake/gdrivefs.git ; extra ==
'tests'"
```
  • Loading branch information
efiop authored Feb 17, 2021
1 parent 5198847 commit 282e83c
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
with:
python-version: 3.8
- name: Install requirements
run: pip install ".[all,tests]" Pygments collective.checkdocs pre-commit
run: pip install ".[all,tests]" Pygments collective.checkdocs pre-commit git+https://github.com/intake/gdrivefs.git
- name: Check README
run: python setup.py checkdocs
- uses: pre-commit/action@v2.0.0
Expand Down
3 changes: 2 additions & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,8 @@ def run(self):
"mypy",
"wsgidav",
"crc32c",
"gdrivefs @ git+https://github.com/intake/gdrivefs.git",
# pypi doesn't allow for direct dependencies
# "gdrivefs @ git+https://github.com/intake/gdrivefs.git",
]

setup(
Expand Down
6 changes: 5 additions & 1 deletion tests/remotes/gdrive.py
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,11 @@ def get_url():
@cached_property
def client(self):
import pydata_google_auth
from gdrivefs import GoogleDriveFileSystem

try:
from gdrivefs import GoogleDriveFileSystem
except ImportError:
pytest.skip("gdrivefs is not installed")

tmp_path = tmp_fname()
with open(tmp_path, "w") as stream:
Expand Down

0 comments on commit 282e83c

Please sign in to comment.