Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dvclive: Document images per step #4750

Merged
merged 1 commit into from
Aug 14, 2023
Merged

dvclive: Document images per step #4750

merged 1 commit into from
Aug 14, 2023

Conversation

daavoo
Copy link
Contributor

@daavoo daavoo commented Aug 11, 2023

No description provided.

@daavoo daavoo added the C: dvclive Content of /doc/dvclive label Aug 11, 2023
@daavoo daavoo requested a review from a team August 11, 2023 10:31
@daavoo daavoo requested a review from a team as a code owner August 11, 2023 10:31
@daavoo daavoo self-assigned this Aug 11, 2023
@shcheklein shcheklein temporarily deployed to dvc-org-dvclive-images--m7g1bn August 11, 2023 10:35 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Aug 11, 2023 •
edited
Loading

Link Check Report

There were no links to check!

dberenbaum
dberenbaum approved these changes Aug 11, 2023
View reviewed changes
Copy link
Contributor

@dberenbaum dberenbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! No blockers, but two follow-ups:

  1. Can you also update the how-it-works example to use this pattern (either here or in a separate PR)?
  2. Is there anywhere in the yolo callback that it can be used?

@shcheklein
Copy link
Member

Is there anywhere in the yolo callback that it can be used?

I've update the callback to "stack" the examples. I'll make a PR soon. They also improved a way to setup it (enable, disable).

Screen.Recording.2023-08-12.at.2.28.15.PM.mov

@shcheklein
Copy link
Member

Also, created a followup for the UX - iterative/vscode-dvc#4493

@daavoo daavoo merged commit ef923f6 into main Aug 14, 2023
@daavoo daavoo deleted the dvclive-images-per-step branch August 14, 2023 09:42
@dberenbaum dberenbaum mentioned this pull request Aug 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shcheklein shcheklein shcheklein approved these changes

@dberenbaum dberenbaum dberenbaum approved these changes

Assignees

@daavoo daavoo

Labels
C: dvclive Content of /doc/dvclive
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daavoo @shcheklein @dberenbaum