-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fetch api values #237
base: legacy
Are you sure you want to change the base?
Fetch api values #237
Conversation
@giosce is attempting to deploy a commit to the dip-trasformazione-digitale Team on Vercel. A member of the Team first needs to authorize it. |
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/dip-trasformazione-digitale/publiccode-editor/31z4i9acjkRWnMwSyhE1zR4AxpGN |
@giosce I'm not convinced by this one, as the editor would generate an invalid One solution could be using a US centric key in a country specific section (and have the editor show the country specific sections based on which countries are enabled in the config file). Alternatively, we can discuss to change the scopes in the Standard for everyone, over at the [Standard's Discussions],(https://github.com/publiccodeyml/publiccode.yml/discussions) and see if it gets traction. |
Thanks Fabio for your feedback. |
@giosce you're welcome! There is a reference validator at https://github.com/italia/publiccode-parser-go which checks for conformance to the publiccode.yml Standard (https://yml.publiccode.tools/). As of now the Standard defines not only the keys in the YAML, but also the value they can hold, in some cases. |
I'm working on adopting public code by a large US organization. We will need more changes, this is a basic one.
My ideal approach is to have as much common code as possible and have country or organization customizations as much as possible in config files.
This change allows to populate the "Scope" dropdown from a different source, in this case from our Taxonomy API. It is backward compatible, if someone doesn't provide a fetch URL the app will continue to work like it is now.
Happy to review/discuss this and other change ideas.