Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: instruction for Windows WSL #146

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Conversation

Zicchio
Copy link
Contributor

@Zicchio Zicchio commented Jul 29, 2024

This pull requests includes 2 modifications:

  1. The script for running the docker compose has been modificed so that it can work on Ubuntu when started from WIndows WSL
  2. The docs now specify that the given tool are not guaranteed to work on base Windows.

This is a partial fix to Issue #145

@@ -12,6 +12,8 @@

## Requirements

The following instructions and provided scripts are intended to be used on a RedHat or Ubuntu based system. Success on Windows based system is currenlty not guaranteed.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The following instructions and provided scripts are intended to be used on a RedHat or Ubuntu based system. Success on Windows based system is currenlty not guaranteed.
The following instructions and provided scripts are intended to be used on a GNU/Linux based system. Success on Windows based system is currently not guaranteed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

applied in 0ac633a

@peppelinux peppelinux requested a review from MdreW August 7, 2024 12:54
@MdreW
Copy link
Collaborator

MdreW commented Aug 23, 2024

Hi @Zicchio , we can remove the localtime mount in docker-compose.yml because this work is executed in the docker build, dockerfile line 21-25

RUN apk update
RUN apk add --update --no-cache tzdata
RUN cp /usr/share/zoneinfo/Europe/Rome /etc/localtime
RUN echo "Europe/Rome" > /etc/timezone
RUN apk del tzdata

@peppelinux , if we don't remove the tzdata package, we can set the timezone with TZ environment, is an "alpine" feature

...but also is so bad UTC? 🤯

@MdreW
Copy link
Collaborator

MdreW commented Aug 23, 2024

A question, are static volumes still necessary?
I know, for a remote orchestrated container is a necessary choice, but in this case run-docker-compose.sh script is not useful.
Otherwise in a local container istance, have a static mount or a local mount is not different.

If manage the static mount is a problemi with WSL, if we should maintain a mixed mount system (some local and some static), we could turn back with the local mount. We can create the requested directory in Docker-compose path (mongodata for the db, satosa for satosa container file and django_sp for django_sp container file)

At this point the script become a simple utility that copy the example file from the repository directory to the container volume path.

All mount are management with same mode, more simplicity for developers and admins. I'm a old poor person and like the simply life 👴
What do you think?

If is useful I can make a example pull request, It wouldn't take me long.

@elisanp
Copy link
Collaborator

elisanp commented Sep 6, 2024

Removing the docker volume and using a shared folder could still be a problem for Windows hosts due to this issue docker-library/mongo#232 (comment), that has as a workaround using an external docker volume as suggested here docker-library/mongo#74 (comment)

@MdreW MdreW marked this pull request as draft November 6, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants