feat(MPDZBS-877): zmscitizenapi into next #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#574) * endpoint working * fix unit tests * one working test for post-reserve * some clean up * feat(ZMS-2517): fix up response for the reserve post request * feat(ZMS-2517): add more unit tests for validations * feat(ZMS-2517): add more unit tests for validations * feat(ZMS-2517): Zmscitizenapi Refactor Part 1 of 3 move controllers back to root * feat(ZMS-2517): Zmscitizenapi Refactor Part 2 of 3 create ZmsApiFacadeService ZmsApiClientService ValidationService MapperService UtilityHelper and delete fragmented services * feat(ZMS-2517): Zmscitizenapi Refactor Part 3 of 3 clean up validations and unit tests --------- Co-authored-by: Thomas Fink <thomasafink@Thomass-MacBook-Air.local>
…by github commit history
* (feat MPDZBS-877) readd citizenapi to htaccess * feat(MPDZBS-877 ZMS-2517): Working Appointment update with too many emails exception * feat(MPDZBS-877 ZMS-2517): Test rendering working for update appointment test * feat(MPDZBS-877 ZMS-2517): Add 63 validation unit tests for appointment update * feat(MPDZBS-877 ZMS-2517): Refactor exception appointmentNotFound * feat(MPDZBS-877 ZMS-2517): Add two new edge case exception tests * feat(MPDZBS-877 ZMS-2517): Remove error_logs --------- Co-authored-by: Thomas Fink <thomasafink@Thomass-MacBook-Air.local>
ThomasAFink
force-pushed
the
feature-MPDZBS-877-zmscitizenapi
branch
from
b57e687
to
1a34881
Compare
ThomasAFink
force-pushed
the
feature-MPDZBS-877-zmscitizenapi
branch
from
1a34881
to
c15dea6
Compare
tobiasholler
requested changes
Nov 20, 2024
Comment on lines
+39
to
+42
| "wget-files": [ | ||
| "wget https://eappointment.gitlab.io/zmsapi/doc/swagger.json -O public/doc/swagger.json", | ||
| "wget https://eappointment.gitlab.io/zmsapi/doc/assets/redoc.min.js -O public/doc/assets/redoc.min.js" | ||
| ], |
There was a problem hiding this comment.
Ich denke mal, das kann in der zmscitizenapi raus.
|
|
||
| * If a new entity definition should be added, the reference must be set here under definitions. | ||
|
|
||
| Translated with www.DeepL.com/Translator (free version) |
There was a problem hiding this comment.
Ich denk mal, das kann weg.
Comment on lines
+1
to
+7
| basePath: /terminvereinbarung/api/2 | ||
| schemes: | ||
| - https | ||
| consumes: | ||
| - application/json | ||
| produces: | ||
| - application/json |
There was a problem hiding this comment.
Bitte für zmscitizenapi anpassen, das sind noch die Werte von zmsapi.
Comment on lines
+1
to
+71
| definitions: | ||
| apikey: | ||
| $ref: "schema/apikey.json" | ||
| apiclient: | ||
| $ref: "schema/apiclient.json" | ||
| appointment: | ||
| $ref: "schema/appointment.json" | ||
| availability: | ||
| $ref: "schema/availability.json" | ||
| calendar: | ||
| $ref: "schema/calendar.json" | ||
| calldisplay: | ||
| $ref: "schema/calldisplay.json" | ||
| client: | ||
| $ref: "schema/client.json" | ||
| cluster: | ||
| $ref: "schema/cluster.json" | ||
| config: | ||
| $ref: "schema/config.json" | ||
| contact: | ||
| $ref: "schema/contact.json" | ||
| day: | ||
| $ref: "schema/day.json" | ||
| department: | ||
| $ref: "schema/department.json" | ||
| dayoff: | ||
| $ref: "schema/dayoff.json" | ||
| exchange: | ||
| $ref: "schema/exchange.json" | ||
| link: | ||
| $ref: "schema/link.json" | ||
| log: | ||
| $ref: "schema/log.json" | ||
| mail: | ||
| $ref: "schema/mail.json" | ||
| mimepart: | ||
| $ref: "schema/mimepart.json" | ||
| metaresult: | ||
| $ref: "schema/metaresult.json" | ||
| notification: | ||
| $ref: "schema/notification.json" | ||
| organisation: | ||
| $ref: "schema/organisation.json" | ||
| owner: | ||
| $ref: "schema/owner.json" | ||
| process: | ||
| $ref: "schema/process.json" | ||
| provider: | ||
| $ref: "schema/provider.json" | ||
| queue: | ||
| $ref: "schema/queue.json" | ||
| request: | ||
| $ref: "schema/request.json" | ||
| requestrelation: | ||
| $ref: "schema/requestrelation.json" | ||
| scope: | ||
| $ref: "schema/scope.json" | ||
| session: | ||
| $ref: "schema/session.json" | ||
| slot: | ||
| $ref: "schema/slot.json" | ||
| source: | ||
| $ref: "schema/source.json" | ||
| status: | ||
| $ref: "schema/status.json" | ||
| ticketprinter: | ||
| $ref: "schema/ticketprinter.json" | ||
| useraccount: | ||
| $ref: "schema/useraccount.json" | ||
| workstation: | ||
| $ref: "schema/workstation.json" |
There was a problem hiding this comment.
Bitte für zmscitizenapi anpassen, das sind noch die Werte von zmsapi.
Comment on lines
+1
to
+27
| info: | ||
| title: ZMS (human waiting queue management) API | ||
| x-logo: | ||
| url: "./logo.png" | ||
| description: | | ||
| The ZMS system is intended to manage human waiting queues. It has the following features: | ||
|
|
||
| * make appointments via a calender and initiate a process to manage an appointment | ||
| * import requests (services) and providers (locations) from external sources | ||
| * manage scopes for appointments, including a four level hierarchy of owner->organisation->department->scope | ||
| * manage opening hours including closed days | ||
| * login-system with different access levels | ||
| * pickup for documents | ||
| * ticketprinter support for customers without appointments (authenticated, lockable, timeable) | ||
| * calldisplay support | ||
| * collecting statistics like waiting time or served clients per day | ||
| * emergency call for employees | ||
|
|
||
| This documentation covers the Citizen Frontend Bürgeransicht API-level access to these features. | ||
| termsOfService: 'http://service.berlin.de/terminvereinbarung/' | ||
| contact: | ||
| name: Mathias Fischer | ||
| email: mathias.fischer@berlinonline.de | ||
| url: 'http://www.berlinonline.net/unternehmen/team/' | ||
| license: | ||
| name: Commercial | ||
| url: 'http://www.berlinonline.net' |
There was a problem hiding this comment.
Bitte für zmscitizenapi anpassen, das sind noch die Werte von zmsapi.
There was a problem hiding this comment.
Wieso nimmst du für basic Validation kein Mellon?
| @@ -10,7 +10,7 @@ | |||
| convertNoticesToExceptions="true" | |||
| convertWarningsToExceptions="true" | |||
| forceCoversAnnotation="false" | |||
| stopOnFailure="true" | |||
| stopOnFailure="false" | |||
There was a problem hiding this comment.
Macht das Sinn das auf false zu setzen?
| stopOnFailure="true" | ||
| stopOnFailure="false" |
There was a problem hiding this comment.
Macht das Sinn das auf false zu setzen?
| @@ -7,7 +7,7 @@ | |||
| convertNoticesToExceptions="true" | |||
| convertWarningsToExceptions="true" | |||
| processIsolation="false" | |||
| stopOnFailure="true" | |||
| stopOnFailure="false" | |||
There was a problem hiding this comment.
Macht das Sinn das auf false zu setzen?
| stopOnFailure="true" | ||
| stopOnFailure="false" |
There was a problem hiding this comment.
Macht das Sinn das auf false zu setzen?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Short description or comments
Reference
Issues #XXX