Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency twig/twig to v3.11.2 [security] #608

Open
wants to merge 1 commit into
base: next
Choose a base branch
from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Oct 8, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
twig/twig (source) 3.11.1 -> 3.11.2 age adoption passing confidence
twig/twig (source) 3.5.1 -> 3.11.2 age adoption passing confidence
twig/twig (source) 3.7.1 -> 3.11.2 age adoption passing confidence
twig/twig (source) 3.6.1 -> 3.11.2 age adoption passing confidence

GitHub Vulnerability Alerts

CVE-2024-45411

Description

Under some circumstances, the sandbox security checks are not run which allows user-contributed templates to bypass the sandbox restrictions.

The security issue happens when all these conditions are met:

  • The sandbox is disabled globally;
  • The sandbox is enabled via a sandboxed include() function which references a template name (like included.twig) and not a Template or TemplateWrapper instance;
  • The included template has been loaded before the include() call but in a non-sandbox context (possible as the sandbox has been globally disabled).

Resolution

The patch ensures that the sandbox security checks are always run at runtime.

Credits

We would like to thank Fabien Potencier for reporting and fixing the issue.

CVE-2024-51754

Description

In a sandbox, an attacker can call __toString() on an object even if the __toString() method is not allowed by the security policy when the object is part of an array or an argument list (arguments to a function or a filter for instance).

Resolution

The sandbox mode now checks the __toString() method call on all objects.

The patch for this issue is available here for the 3.11.x branch, and here for the 3.x branch.

Credits

We would like to thank Jamie Schouten for reporting the issue and Fabien Potencier for providing the fix.

CVE-2024-51755

Description

In a sandbox, and attacker can access attributes of Array-like objects as they were not checked by the security policy.
They are now checked via the property policy and the __isset() method is now called after the security check.
This is a BC break.

Resolution

The sandbox mode now ensures access to array-like's properties is allowed.

The patch for this issue is available here for the 3.11.x branch, and here for the 3.x branch.

Credits

We would like to thank Jamie Schouten for reporting the issue and Nicolas Grekas for providing the fix.


Release Notes

twigphp/Twig (twig/twig)

v3.11.2

Compare Source

  • [BC BREAK] Fix a security issue in the sandbox mode allowing an attacker to call attributes on Array-like objects
    They are now checked via the property policy
  • Fix a security issue in the sandbox mode allowing an attacker to be able to call toString()
    under some circumstances on an object even if the __toString() method is not allowed by the security policy

Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@ThomasAFink ThomasAFink changed the base branch from main to next October 8, 2024 11:00
@renovate renovate bot force-pushed the renovate/packagist-twig-twig-vulnerability branch from 38a0625 to 41aeae7 Compare October 8, 2024 11:17
@renovate renovate bot changed the title Update dependency twig/twig to v3.11.1 [SECURITY] fix(deps): update dependency twig/twig to v3.11.1 [security] Oct 8, 2024
@renovate renovate bot changed the title fix(deps): update dependency twig/twig to v3.11.1 [security] Update dependency twig/twig to v3.11.1 [SECURITY] Oct 8, 2024
@renovate renovate bot changed the title Update dependency twig/twig to v3.11.1 [SECURITY] fix(deps): update dependency twig/twig to v3.11.1 [security] Oct 9, 2024
@renovate renovate bot changed the title fix(deps): update dependency twig/twig to v3.11.1 [security] Update dependency twig/twig to v3.11.1 [SECURITY] Oct 9, 2024
@renovate renovate bot changed the title Update dependency twig/twig to v3.11.1 [SECURITY] fix(deps): update dependency twig/twig to v3.11.1 [security] Oct 11, 2024
@renovate renovate bot force-pushed the renovate/packagist-twig-twig-vulnerability branch 2 times, most recently from 5af2561 to 0450016 Compare November 6, 2024 22:02
@renovate renovate bot changed the title fix(deps): update dependency twig/twig to v3.11.1 [security] fix(deps): update dependency twig/twig to v3.11.2 [security] Nov 6, 2024
@renovate renovate bot force-pushed the renovate/packagist-twig-twig-vulnerability branch from 0450016 to 5110866 Compare November 12, 2024 20:42
@renovate renovate bot changed the title fix(deps): update dependency twig/twig to v3.11.2 [security] fix(deps): update dependency twig/twig to v3.11.1 [security] Nov 12, 2024
@renovate renovate bot force-pushed the renovate/packagist-twig-twig-vulnerability branch from 5110866 to f62e609 Compare November 12, 2024 20:57
@renovate renovate bot changed the title fix(deps): update dependency twig/twig to v3.11.1 [security] fix(deps): update dependency twig/twig to v3.11.2 [security] Nov 12, 2024
@renovate renovate bot force-pushed the renovate/packagist-twig-twig-vulnerability branch from f62e609 to 8c0fa4e Compare November 12, 2024 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants