-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/add multi grade rules #873
Open
GabrielChagas14
wants to merge
10
commits into
dev
Choose a base branch
from
feat/add-multi-grade-rules
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GabrielChagas14
requested review from
igorgoncalves,
AnotherOne07 and
Gusta-Santos
November 12, 2024 18:37
Gusta-Santos
approved these changes
Nov 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Quality Gate passedIssues Measures |
AnotherOne07
approved these changes
Nov 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏾 LGTM
AnotherOne07
added
Pronto para merge
reviews feitas e aprovadas
and removed
Aguardando review 1
labels
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivação
TCDA-713: O município de Muribeca solicitou que, para as turmas multisseriadas, fosse possível cadastrar diferentes estruturas de notas de acordo com a etapa de ensino. Por exemplo, em uma turma multisseriada com 1º, 2º e 3º anos, a estrutura de notas seria por conceito para os alunos do 1º e 2º anos, enquanto para os alunos do 3º ano seria numérica.
Alterações Realizadas
Para realizar a tarefa, foi necessário criar um novo filtro na tela de notas, que aparece apenas quando uma turma multisseriada é selecionada no seletor de turmas. Esse filtro permite que os alunos sejam filtrados por etapa de ensino, uma vez que, em turmas multisseriadas, há alunos de etapas diferentes na mesma turma. Com isso, é possível validar qual estrutura de notas deve ser considerada ao renderizar a tela de notas, levando em consideração a etapa vinculada à matrícula dos alunos na turma multisseriada.
Fluxo de Teste
🧪 Teste 1
🧪 Teste 2
Migrations Utilizadas
Checklist de revisão
config.php
?CHANGELOG
?