Fix/multiselects #532
Open
Fix/multiselects #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed! |
|
igorgoncalves
requested changes
Dec 26, 2023
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The default select was confusing for some users, since when many alternatives were selected the input did not visually accommodate them all, appearing to have no selections.
Changes Made
Changing the default select to a modal that contains a select that increases the size according to the selected options.
Changing the select to an input that calls the modal containing the school selection select.
Test Flow
Registered available users (Administrator, teacher and school manager) testing different numbers of schools.
Log in with registered users and check the number of schools and other information added.
Migrations Used
None
Accessibility testing