Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/Class refactoring #512

Open
wants to merge 45 commits into
base: dev
Choose a base branch
from
Open

Fix/Class refactoring #512

wants to merge 45 commits into from

Conversation

Tori-IPTI
Copy link
Contributor

Correction made to the class screen.
Updated modal for adding teacher and curricular components.
Updated selects.

Copy link

sonarcloud bot commented Dec 26, 2023

Quality Gate Failed Quality Gate failed

Failed conditions

D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

Copy link
Member

@igorgoncalves igorgoncalves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nome da branch fora do padrão:

O nome deve começar com feat/ se for uma nova funcionalidade ou uma nova versão de uma funcionalidade que já existe. Caso seja uma correção para um erro, então deve começar como fix/

Copy link
Member

@igorgoncalves igorgoncalves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

O sonar cloud está rejeitando a pullrequest devido a um bug que foi introduzido, corrija o erro.

https://sonarcloud.io/summary/new_code?id=ipti_br.tag&pullRequest=512

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants