feat!: config is always visible on landing page #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SgtPooki
commented
Dec 2, 2024
|
|
||
| const isRequestToViewConfigPage = isConfigPage(window.location.hash) | ||
| return isRequestToViewConfigPage | ||
| return isRequestToViewConfigPage && isSubdomainGatewayRequest(window.location) |
There was a problem hiding this comment.
only render this individual config page on subdomain requests explicitly for /#/ipfs-sw-config
2color
reviewed
Dec 3, 2024
2color
approved these changes
Dec 3, 2024
Co-authored-by: Daniel Norman <1992255+2color@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
feat!: config is always visible on landing page
Description
This change adds the config section to the main landing page (i.e. helper-ui.tsx) and removes the config gear icon in the header, and direct access to an isolated config page (unless on a subdomain)
Some heading text was also added to the config to make it more clear that it is a config section.
Fixes #486
Notes & open questions
We still have a page accessible at /#/ipfs-sw-config for subdomain users to be able to edit the config, and a test for that now.
Change checklist