Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update usages of id() to api.address() #98

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Update usages of id() to api.address() #98

wants to merge 7 commits into from

Conversation

ionite34
Copy link
Owner

@ionite34 ionite34 commented May 5, 2023

Improvements

  • Updated all usages of the id() function to api.address() to prevent issues when id() is replaced and to better support other python implementations where id() is not the memory address.

@codecov
Copy link

codecov bot commented May 5, 2023

Codecov Report

Merging #98 (1e35daf) into main (640e7bf) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #98      +/-   ##
==========================================
+ Coverage   92.54%   92.55%   +0.01%     
==========================================
  Files          51       51              
  Lines        2801     2803       +2     
==========================================
+ Hits         2592     2594       +2     
  Misses        209      209              
Flag Coverage Δ
unittests 92.55% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/einspect/__init__.py 100.00% <100.00%> (ø)
src/einspect/_patch.py 100.00% <100.00%> (ø)
src/einspect/structs/py_set.py 100.00% <100.00%> (ø)
src/einspect/structs/py_type.py 87.81% <100.00%> (+0.08%) ⬆️
src/einspect/views/view_base.py 92.93% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 640e7bf...1e35daf. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant