Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vscode settings #65

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add vscode settings #65

wants to merge 2 commits into from

Conversation

gyagp
Copy link
Contributor

@gyagp gyagp commented Oct 8, 2024

Maybe this is more friendly for vscode users like me.

@gyagp
Copy link
Contributor Author

gyagp commented Oct 8, 2024

@NingW101 Do you think if we can add vscode settings to make linter more automatic?

@NingW101 NingW101 self-requested a review October 9, 2024 02:02
@NingW101
Copy link
Contributor

NingW101 commented Oct 9, 2024

@NingW101 Do you think if we can add vscode settings to make linter more automatic?

The developers using other editor | IDE still troubled by format issues. I think the key point is prompt developers when format does not match the rule since we have provided the npm run format command to help automatically format.

Actually we added the format as eslint rules, then linting check action will check the PR and report format error, but it seems not work right now, I'll check and fix it.

What's more, we can introduce husky to do linting check before developers git commit, then the PRs will not exist any linting errors.

@gyagp
Copy link
Contributor Author

gyagp commented Oct 9, 2024

I also prefer husky for pre-commit hook ;) vscode setting could be complementary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants