-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add python support to ITT API #145
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
abrown
reviewed
May 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eparshut asked me to take a look at this so here are some thoughts:
- First, I think this is great! Having control over collection in more languages is extremely helpful; I wasn't even aware this existed until I saw it upstreamed here.
- A naming nit: I would probably go with
python
as the top-level directory for this code to match therust
directory. And I would have expected the PyPI package to be namedittapi
, but it's probably too late to change that. - I noticed different coding styles throughout; maybe we should add a formatter pass in CI
- Which brings me to CI: this addition would really benefit from building itself in a GitHub workflow, running the tests, running lints, etc.
esuldin
suggested changes
May 23, 2024
lubomirov
suggested changes
May 27, 2024
eparshut
commented
May 27, 2024
The usage of Intel email address is not align with Own-Time Open Source Project Approval that pyitt has. Therefore, please use original email address or just remove it at all from pyproject.toml. |
lubomirov
suggested changes
Jun 6, 2024
eparshut
commented
Jun 12, 2024
eparshut
changed the title
[WIP] Add python support to ITT API
Add python support to ITT API
Jun 19, 2024
lubomirov
approved these changes
Jun 20, 2024
lalithsharan-intel
approved these changes
Jun 20, 2024
Andy51
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Python binding to ITT API.
Many kudos to @esuldin for the work done and his contribution.