Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export client request latencies as histograms #90

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Export client request latencies as histograms #90

wants to merge 1 commit into from

Commits on Sep 3, 2020

  1. Export client request latencies as histograms 

    This adds support for histogram-style metrics instead of using
summaries. It means we can sum on a cluster level and present the user's
experienced latency instead of looking at it on a per-node level.

The current version limits the range of histogram buckets between 0.1ms
and 60s, to avoid exporting huge amounts of buckets that are likely
empty. Further patches could limit this further, for example by going
for a 1.44x increment instead of the 1.2x increment, or by specifying
the ranges in the configuration.

Even with the limits in place, this exports 76 metrics to 3 metric
families per histogram. The original summaries-based code only exports 8
metrics (in 3 families), though in theory those are no longer needed and
could be disabled with a flag.
    @TvdW
    TvdW committed Sep 3, 2020
    Configuration menu
    Copy the full SHA
    a22cde2 View commit details
    Browse the repository at this point in the history