-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #11: improve parsing #57
Conversation
That's now how I would like to approach this. I would prefer if foliage would give a parsing error. I guess |
I think this is a limitation of tomland. There is no way to describe a field that has a definite value type but can be missing. The only I had a go writing a "maybe" version of match, here. Perhaps, the easiest approach could be to intercept the |
I found a related discussion on the tomland repo. |
63fc5fa
to
f0e14e5
Compare
f0e14e5
to
c5d918c
Compare
Marking this as draft, let me know when you think it's ready. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might work but we need tests make sure it does. Could you rebase on top of #81 and add a couple of tests?
983296c
to
adcabcd
Compare
co-authored by @andreabedini
adcabcd
to
9f7dafc
Compare
Seems like it does not work as expected https://github.com/input-output-hk/foliage/pull/57/checks?check_run_id=17034377725 :/ |
No description provided.