-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DAC-340 [FE] Stop a test campaign #48
Conversation
@bogdan-manole , to be reviewed only after #46 is closed |
@bogdan-manole ready to review |
disabled={!form.formState.isValid || submitting} | ||
onClick={(_) => setFormSubmitted(true)} | ||
/> | ||
{(apiFetching && submitting) && ( | ||
<Button |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if adding some extra status condition for this button is the case, but I'm wondering if you have to add a condition for this abort button's visibility when the certification has already started.
There is no way to abort/delete a Run after the certification was started. At least not for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Must be ideal to hold this until ready-for-certification runStatus is integrated. Will revisit this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clarification - 'Abort Run' button will be visible only until status: finished
, i.e. only visible when the test campaign is still running.
I've integrated aborted
and ready-for-certification
statuses into History table, also made sure to prevent delete of any campaign from history if the runStatus: ready-for-certification
.
… table; show view report + prevent delete if ready-for-certification
https://input-output.atlassian.net/browse/DAC-340