Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAC-340 [FE] Stop a test campaign #48

Merged
merged 9 commits into from
Mar 9, 2023
Merged

DAC-340 [FE] Stop a test campaign #48

merged 9 commits into from
Mar 9, 2023

Conversation

amnambiar
Copy link
Collaborator

@amnambiar
Copy link
Collaborator Author

@bogdan-manole , to be reviewed only after #46 is closed

@amnambiar
Copy link
Collaborator Author

@bogdan-manole ready to review

disabled={!form.formState.isValid || submitting}
onClick={(_) => setFormSubmitted(true)}
/>
{(apiFetching && submitting) && (
<Button
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if adding some extra status condition for this button is the case, but I'm wondering if you have to add a condition for this abort button's visibility when the certification has already started.
There is no way to abort/delete a Run after the certification was started. At least not for now.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Must be ideal to hold this until ready-for-certification runStatus is integrated. Will revisit this PR

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clarification - 'Abort Run' button will be visible only until status: finished, i.e. only visible when the test campaign is still running.

I've integrated aborted and ready-for-certification statuses into History table, also made sure to prevent delete of any campaign from history if the runStatus: ready-for-certification.

@amnambiar amnambiar merged commit 4810abd into master Mar 9, 2023
@amnambiar amnambiar deleted the DAC-340 branch March 9, 2023 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants