Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow running without wallet props if running in-memory ledger #827

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ghost
Copy link

@ghost ghost commented Sep 13, 2023

Overview

Prevously - PRISM Node cannot be run in-memory without creating secrets for cardano wallet - which aren’t used

Now → Allow PRISM node to run without the need for secrets - this means don’t specify the environment variables and pull from secrets unless it’s actually running against a real test-net

Screenshots

Checklists

Pre-submit checklist:

  • Self-reviewed the diff
  • New code has proper comments/documentation/tests
  • Any changes not covered by tests have been tested manually
  • The README files are updated
  • If new libraries are included, they have licenses compatible with our project
  • If there is a db migration altering existing tables, there is a proper migration test

Pre-merge checklist:

  • Commits have useful messages
  • Review clarifications made it into the code

@ghost ghost changed the title feature/atl-5753-no-secret-required-for-in-memory-ledger-in-k8s feat: allow running without wallet props if running in-memory ledger Sep 13, 2023
@atala-dev
Copy link
Contributor

atala-dev commented Sep 13, 2023

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors
✅ REPOSITORY dustilock yes no
✅ REPOSITORY git_diff yes no
✅ REPOSITORY syft yes no

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

Signed-off-by: David Poltorak <david.poltorak@iohk.io>
Signed-off-by: David Poltorak <david.poltorak@iohk.io>
@ghost ghost force-pushed the feature/atl-5753-no-secret-required-for-in-memory-ledger-in-k8s branch from 8474430 to 67fc735 Compare September 13, 2023 09:59
@github-actions
Copy link

Unit Test Results

328 tests  ±0   327 ✔️ ±0   37s ⏱️ -1s
  48 suites ±0       1 💤 ±0 
  48 files   ±0       0 ±0 

Results for commit 67fc735. ± Comparison against base commit 30a8164.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants