Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: nginx sec headers #4397

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

feat: nginx sec headers #4397

wants to merge 7 commits into from

Conversation

Lennart01
Copy link
Member

Description

Changelog

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • The light- and dark-theme are both supported and tested
  • The design was implemented and is responsive for all devices and screen sizes
  • The application was tested in the most commonly used browsers (e.g. Chrome, Firefox, Safari)

(Optional) Visual Changes

Copy link

github-actions bot commented Aug 8, 2024

The deployment to the dev cluster was successful. You can find the deployment here: https://4397.development.scrumlr.fra.ics.inovex.io
This deployment is only for testing purposes and will be deleted after 1 week.
To redeploy rerun the workflow.
DO NOT STORE IMPORTANT DATA ON THIS DEPLOYMENT

Deployed Images
  • ghcr.io/inovex/scrumlr.io/scrumlr-frontend:sha-f1f17c7

  • ghcr.io/inovex/scrumlr.io/scrumlr-server:sha-f1f17c7

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm usually a proponent of splitting stuff into multiple files, however I'm not sure in this case because it adds another file to the project root. Could you add in into the main file or if you want to split it maybe add a subdirectory?

@Schwehn42 Schwehn42 added the Changes Requested Changes requested by the reviewer label Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes Requested Changes requested by the reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants