fix: replace deprecated 'dropdown' with menu and select in patterns #2395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
Replaces the deprecated "Dropdown" component with Menu and Select components in Patterns sections (specifically Create User, Inline Form, Inline Label Form, Stepper Form, Time Period Form, and Table with Header)
Does this close any currently open issues?
Closes #2391
Comments
Table with Header was harder than I thought it would be to implement as each form contains a "Select All" box, a cancel button, and an apply button, and these all need their own separate handler functions and variables keeping track of what is and isn't selected to maintain the same functionality as the Dropdown
Checklist
Check all those that are applicable and complete.
masterbranch