Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate GrowingStore and RevertibleStore #182

Merged
merged 5 commits into from
May 10, 2024
Merged

deprecate GrowingStore and RevertibleStore #182

merged 5 commits into from
May 10, 2024

Conversation

rnbguy
Copy link
Member

@rnbguy rnbguy commented May 9, 2024

Close #181

These two stores are incorrect.

Now that the InMemoryStore directly supports deletion, rollbacks, and non-membership proofs - we can deprecate these stores.

@rnbguy rnbguy changed the title deprecates GrowingStore and RevertibleStore deprecate GrowingStore and RevertibleStore May 9, 2024
@rnbguy rnbguy mentioned this pull request May 9, 2024
Closed
@rnbguy rnbguy requested a review from seanchen1991 May 9, 2024 12:30
seanchen1991
seanchen1991 approved these changes May 9, 2024
View reviewed changes
Copy link
Contributor

@seanchen1991 seanchen1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we going to be updating the since fields of the deprecated attributes?

basecoin/store/src/impls/growing.rs Outdated Show resolved Hide resolved
basecoin/store/src/impls/revertible.rs Outdated Show resolved Hide resolved
basecoin/store/src/impls/revertible.rs Outdated Show resolved Hide resolved
@rnbguy
Copy link
Member Author

rnbguy commented May 10, 2024 •
edited
Loading

The since fields are set to TBD as there is no release version yet.

Nonetheless, TBD is a valid value for since - it is interpreted as planned for deprecation in future version.

We can update it when we release a version.

rnbguy and others added 3 commits May 10, 2024 08:03
@seanchen1991 seanchen1991 merged commit cd793b8 into main May 10, 2024
10 checks passed
@seanchen1991 seanchen1991 deleted the rano/fix/181 branch May 10, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanchen1991 seanchen1991 seanchen1991 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

deprecate Growing and Revertible Stores
2 participants
@rnbguy @seanchen1991