revise WriteAPI.Flush to attempt to send batches in the retry queue #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The length of an unbuffered channel is always zero, and all checked channels are unbuffered, so all flush does is a transient synchronization with the writeProc and bufferProc goroutines. Remove the unnecessary logic. Signed-off-by: Peter A. Bigot <pab@pabigot.com>
Flush() is documented to force all pending writes from the buffer to be sent. It does force pending writes in the buffer to be submitted for send, but if there is a pending retry with an unexpired timeout it won't actually send anything. Make Flush() more useful by having it trigger a re-examination of the retry queue and initiating a retry immediately. Depending on whether the documented behavior was intentional, this operation might be better implemented as an additional WriteAPI method FlushAll(). Signed-off-by: Peter A. Bigot <pab@pabigot.com>
|
After further consideration this doesn't meet my needs: it avoids data loss in successful reconnection cases, but on shutdown the flush operation would provide a callback only for one queued batch per flush, so recovery of submitted data would be tedious. Also the fact that the batch processing will discard data without programmatically notifying the client if the queue length gets too long is a showstopper. So I'm going to stick with the blocking API. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #289
Closes #290
Proposed Changes
After completing standard flush operations that move points from the buffer to queued batch, trigger a re-examination of retries rather than waiting for a timeout.
Also incorporates the cleanup patch for #290.
Checklist
I'll address these if it appears this is an acceptable solution to the problem described in #289.