A few fixes #13
A few fixes #13
Conversation
|
In regards to e5f5373: The assumption that you're receiving broadcasts to If you want to extend this functionality in the future to do things other than Furthermore, the search should not be limited to one result. Since you're searching multiple networks, you should get back an array. This patch set is just for fixing bugs. I've started a rewrite that simplifies the code a lot and before I pull request that in as a solid 1.0 I'll probably allow multiple ssdp search results. |
| @@ -14,8 +14,8 @@ client.create = function create() { | |||
|
|
|||
| function normalizeOptions(options) { | |||
| function toObject(addr) { | |||
| if (typeof addr === 'number') return { port: addr }; | |||
| if (typeof addr === 'object') return addr; | |||
| if (typeof addr === 'number') { return { port: addr }; } | |||
There was a problem hiding this comment.
Wow, please don't do this here :)
There was a problem hiding this comment.
You mean add curly braces?
I've come across so many errors that result from not using braces when working with others. I'm a very very strict linter. If in doubt, spell it out.
That said, it's your code. I tried to make lint commits separate from code commits.
There was a problem hiding this comment.
This is quite consistent with node.js code style. Though, we usually put statement on a next line.
Anyway, it would be really great if this project will be using jscs for code style checking. I have suggested a configuration file in another comment, do you think it might be interesting for you to implement?
|
@coolaj86 may I ask you to do it without style fixes for now? Or take |
|
How does one switch to using jscs? I installed it and I see the syntastic file exists, but where jshint gives hints every time I save in vim, jscs seems to do... nothing. Googling... was kinda hoping it would just be add a line to my vimrc or something. Hints? |
|
Figured it out: https://coolaj86.com/articles/jscs-jscsrc-vim-syntastic-and-you/ Now going on to make rewrite my curly braces... |
|
jscs doesn't have an option for enforcing curly braces in the way you suggest (see jscs-dev/node-jscs#244) but I used grep to make sure I set everything back. |
|
Landed in ae7724a, thank you! |
A few fixes for #3 #9 #12 and also #11.