Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add all ip 0.0.0.0 to isPrivate and isLoopback #68

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

littleskunk
Copy link

#50

@lilyannehall
Copy link

I think practically it makes sense to treat 0.0.0.0 this way, but technically since it's a meta-address that means "all available ipv4 addresses" its not really a loopback or private IP. I wonder if there should be an additional method like isRoutable that checks for this instead of classifying it as a loopback interface.

@littleskunk
Copy link
Author

I agree on that as long as the ipv6 equivalent :: is treated the same way.

I will wait for a decision.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants