Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove check_species(), get_scientific_name() #235

Open
peterdesmet opened this issue Jul 13, 2023 · 1 comment · May be fixed by #346
Open

Remove check_species(), get_scientific_name() #235

peterdesmet opened this issue Jul 13, 2023 · 1 comment · May be fixed by #346
Milestone

Comments

@peterdesmet
Copy link
Member

Suggested in camtraptor July 2023 coding sprint

The functions get_scientific_name() returns a vector of scientific names for provided vernacular names, within the scope of a package. It does not allow scientific name values:

> get_scientific_name(mica, c("bever", "mens"))
[1] "Castor fiber" "Homo sapiens"

> get_scientific_name(mica, c("bever", "mens", "Ardea")
+ )
Error: Invalid value for vernacular_name parameter: ardea.
Valid inputs are: mallard, gadwall, great herons, grey heron, eurasian beaver, human, beech marten, european polecat, red fox, wilde eend, krakeend, reigers, blauwe reiger, bever, mens, steenmarter, bunzing and vos.

The function check_species() returns a vector of scientific names for provided vernacular names and scientific names, within the scope of a package:

> check_species(mica, c("bever", "mens", "ardea"))
Scientific name of bever: Castor fiber
Scientific name of mens: Homo sapiens
[1] "Castor fiber" "Homo sapiens" "Ardea" 

We think these functions are no longer necessary:

  • The current functions are confusing (what is their difference?)
  • The current functions translate vernacular names to scientific names, but only based on the info that is available in a package. So one could not get a result because the species is not present or (worse) the species is present, but the vernacular name is not included.
  • The suggested taxonomy() Update get_species() to taxonomy() #115 function provides an overview of taxa that are present in a (filtered) package in a tabular format. That information is easier to scan for existing (and missing) vernacular names that the current functions.
  • The suggested filter_ functions Create filter_deployments(), filter_observations(), filter_media() camtrapdp#23 allow to search on any column, e.g. scientificName, vernacularName.nld etc. Having functions that convert vernacular names to scientific names are less useful here.
@damianooldoni
Copy link
Member

Agree. To be added to defunct functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants