Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: reduce number of layers #2

Merged
merged 9 commits into from
Oct 12, 2023
Merged

refactor: reduce number of layers #2

merged 9 commits into from
Oct 12, 2023

Conversation

martabal
Copy link
Member

Since this is a base image, we can reduce the number of layers to reduce the image size. The only side effect is that we can't use cache to speed up the build.

Added a crontab too in the github workflow so it builds the image automatically every 3 days.

@martabal martabal force-pushed the refactor/reduce-layers branch 2 times, most recently from c81b697 to af51819 Compare October 12, 2023 13:23
@martabal martabal force-pushed the refactor/reduce-layers branch 2 times, most recently from 25688cb to 67d7e66 Compare October 12, 2023 14:55
@bo0tzz
Copy link
Member

bo0tzz commented Oct 12, 2023

Thank you for tidying up the layers! I don't think we need the cron build, and we should discuss how exactly we want to build this anyways (ie whether it stays in this separate repo).

@martabal
Copy link
Member Author

Thank you for tidying up the layers! I don't think we need the cron build, and we should discuss how exactly we want to build this anyways (ie whether it stays in this separate repo).

I removed the cron build 😃

@bo0tzz bo0tzz merged commit 7b46bdb into main Oct 12, 2023
2 checks passed
@bo0tzz bo0tzz deleted the refactor/reduce-layers branch November 18, 2023 16:38
mertalev added a commit that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants