-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: reduce number of layers #2
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martabal
force-pushed
the
refactor/reduce-layers
branch
2 times, most recently
from
October 12, 2023 13:23
c81b697
to
af51819
Compare
martabal
force-pushed
the
refactor/reduce-layers
branch
from
October 12, 2023 13:23
af51819
to
458426b
Compare
martabal
force-pushed
the
refactor/reduce-layers
branch
from
October 12, 2023 14:21
0fb16ae
to
5615154
Compare
martabal
force-pushed
the
refactor/reduce-layers
branch
2 times, most recently
from
October 12, 2023 14:55
25688cb
to
67d7e66
Compare
martabal
force-pushed
the
refactor/reduce-layers
branch
from
October 12, 2023 14:57
67d7e66
to
182cfe0
Compare
Thank you for tidying up the layers! I don't think we need the cron build, and we should discuss how exactly we want to build this anyways (ie whether it stays in this separate repo). |
I removed the cron build 😃 |
martabal
force-pushed
the
refactor/reduce-layers
branch
from
October 12, 2023 16:14
5f72636
to
3ca191d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since this is a base image, we can reduce the number of layers to reduce the image size. The only side effect is that we can't use cache to speed up the build.
Added a crontab too in the github workflow so it builds the image automatically every 3 days.