Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create image verification portal #8 #9

Merged
merged 4 commits into from
Sep 5, 2024
Merged

Create image verification portal #8 #9

merged 4 commits into from
Sep 5, 2024

Conversation

zachale
Copy link
Collaborator

@zachale zachale commented Jul 1, 2024

Added

  • GET endpoint that returns image verification portal
  • POST endpoint that updates an images status
  • DELETE endpoint that deletes all images with the rejected status

Screenshots

image

@faisal-fawad
Copy link
Collaborator

Waiting for demo.

@zachale zachale marked this pull request as ready for review July 6, 2024 14:45
@zachale zachale force-pushed the 8-create-image-verification-portal branch from 1c61987 to d3b6af9 Compare July 6, 2024 15:01
faisal-fawad
faisal-fawad reviewed Jul 7, 2024
View reviewed changes
Copy link
Collaborator

@faisal-fawad faisal-fawad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outdated, but forgot to comment this change

demo/app.py Outdated Show resolved Hide resolved
nathan-probert
nathan-probert reviewed Jul 12, 2024
View reviewed changes
demo/app.py Outdated Show resolved Hide resolved
@zachale zachale force-pushed the 8-create-image-verification-portal branch from d3b6af9 to 0357e5d Compare July 14, 2024 15:18
faisal-fawad
faisal-fawad previously approved these changes Jul 16, 2024
View reviewed changes
Copy link
Collaborator

@faisal-fawad faisal-fawad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nathan-probert
nathan-probert requested changes Jul 27, 2024
View reviewed changes
imaginate_api/app.py Outdated Show resolved Hide resolved
imaginate_api/app.py Outdated Show resolved Hide resolved
@zachale zachale changed the title create image verification portal #8 Create image verification portal #8 Jul 28, 2024
@zachale zachale self-assigned this Jul 28, 2024
@zachale zachale added enhancement New feature or request Priority 1 Maximum priority labels Jul 28, 2024
@zachale zachale force-pushed the 8-create-image-verification-portal branch 2 times, most recently from e2148f6 to 4149cc0 Compare July 31, 2024 01:24
zachale
zachale commented Jul 31, 2024
View reviewed changes
tests/unit/test_app.py Outdated Show resolved Hide resolved
@zachale zachale force-pushed the 8-create-image-verification-portal branch 2 times, most recently from 2a3a7ae to c367a5b Compare September 3, 2024 00:12
@zachale zachale force-pushed the 8-create-image-verification-portal branch from c367a5b to 21b6f72 Compare September 3, 2024 00:59
nathan-probert
nathan-probert previously approved these changes Sep 5, 2024
View reviewed changes
@zachale @faisal-fawad
Update imaginate_api/image/routes.py
db702b6 
Co-authored-by: Faisal Fawad <76597599+faisal-fawad@users.noreply.github.com>
@faisal-fawad faisal-fawad merged commit a8cf1f0 into main Sep 5, 2024
3 checks passed
@faisal-fawad faisal-fawad deleted the 8-create-image-verification-portal branch September 5, 2024 22:37
@faisal-fawad faisal-fawad mentioned this pull request Sep 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathan-probert nathan-probert nathan-probert approved these changes

@faisal-fawad faisal-fawad faisal-fawad approved these changes

Assignees

@zachale zachale

Labels
enhancement New feature or request Priority 1 Maximum priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zachale @faisal-fawad @nathan-probert