Created date util #19 #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachale
commented
Jul 28, 2024
| @@ -150,7 +169,7 @@ def test_post_image_create_endpoint_success(client, mock_data): | |||
| assert res.json == build_result( | |||
| res.json["url"].split("/")[-1], | |||
| entry["real"], | |||
| entry["date"], | |||
| calculate_date(entry["date"]), | |||
There was a problem hiding this comment.
This is a bandaid until my other PR is merged with a better setup for data in the mock FS
faisal-fawad
reviewed
Aug 9, 2024
imaginate_api/demo.py
Outdated
| from ImageHandler import ImageHandler | ||
| from schemas.image_info import ImageInfo | ||
| from imaginate_api.image_handler import ImageHandler | ||
| from imaginate_api.schemas.image_info import ImageInfo |
There was a problem hiding this comment.
Suggested change
| from imaginate_api.schemas.image_info import ImageInfo | |
| from image_handler_client.schemas.image_info import ImageInfo |
Since the schema has been moved to that repository
faisal-fawad
reviewed
Aug 9, 2024
.github/workflows/pipeline.yml
Outdated
| @@ -59,7 +59,7 @@ jobs: | |||
| envkey_MONGO_TOKEN: ${{ secrets.MONGO_TOKEN }} | |||
| file_name: .env | |||
| - name: Run tests | |||
| run: poetry run pytest --doctest-modules --junitxml=junit/test-results.xml | |||
| run: poetry run pytest tests/unit/test_app.py --doctest-modules --junitxml=junit/test-results.xml | |||
There was a problem hiding this comment.
Suggested change
| run: poetry run pytest tests/unit/test_app.py --doctest-modules --junitxml=junit/test-results.xml | |
| run: poetry run pytest --doctest-modules --junitxml=junit/test-results.xml |
zachale
force-pushed
the
19-create-date-util
branch
from
a4fda87
to
60f1a26
Compare
zachale
commented
Aug 9, 2024
|
|
||
| # helper function that returns a timestamp as an integer, no matter if day is inputed as a timestamp or day # | ||
| # WARNING, do not enter a timestamp from BEFORE august 1st 2024. | ||
| def calculate_date(day: str | int): |
There was a problem hiding this comment.
This now takes in a string OR integer, calculates a timestamp and returns it as an integer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview