Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to find nvngx path #1

Merged
merged 5 commits into from
Aug 8, 2023
Merged

Add ability to find nvngx path #1

merged 5 commits into from
Aug 8, 2023

Conversation

Etaash-mathamsetty
Copy link
Contributor

@Etaash-mathamsetty Etaash-mathamsetty commented Aug 8, 2023 •
edited
Loading

could you test this @ imLinguin

imLinguin
imLinguin approved these changes Aug 8, 2023
View reviewed changes
Copy link
Owner

@imLinguin imLinguin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I guess we don't need to serialize the string to JSON, as it is as simple as just reading stdout.
P.S. Yes it works in flatpak too

@imLinguin imLinguin merged commit 6fa3b2e into imLinguin:main Aug 8, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imLinguin imLinguin imLinguin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Etaash-mathamsetty @imLinguin