Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #199 - Fixed class name in DataMigrate::Migration.check_pending! #200

Closed

Conversation

sully7
Copy link
Contributor

@sully7 sully7 commented Jan 6, 2022

DataMigrator::Migrator.needs_migration? should be DataMigrator::DataMigrator.needs_migration?

`DataMigrator::Migrator.needs_migration?` should be `DataMigrator::DataMigrator.needs_migration?`
@sully7 sully7 changed the title Fixed class name in DataMigrate::Migration.check_pending! Fixes #199 - Fixed class name in DataMigrate::Migration.check_pending! Jan 6, 2022
@sully7
Copy link
Contributor Author

sully7 commented Jan 6, 2022

Fixes #199

@ilyakatz
Copy link
Owner

ilyakatz commented Jan 6, 2022

Cool, thanks for finding this. I think this was an old name. Guess there were no tests for this. Do you think it's worth adding one?

@ilyakatz
Copy link
Owner

ilyakatz commented Aug 2, 2022

hi @sully7 are you still interested in completing this one?

@ilyakatz
Copy link
Owner

will close it out since there hasn't been any action

@ilyakatz ilyakatz closed this Mar 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants