Skip to content
This repository has been archived by the owner on Mar 29, 2023. It is now read-only.

BUG: Fix import for new versions of ibis #59

Merged
merged 1 commit into from
May 20, 2021

Conversation

gerrymanoim
Copy link
Contributor

@jreback
Copy link

jreback commented May 20, 2021

@tswast any issues here?

@tswast
Copy link
Collaborator

tswast commented May 20, 2021

I'd also like to make sure we maintain compatibility with ibis 1.4.0. At least until there are a few 2.x releases. I see there are some failing test in that build. https://github.com/ibis-project/ibis-bigquery/pull/59/checks?check_run_id=2630857546

e.g.

Run python -m pytest tests/unit
============================= test session starts ==============================
platform linux -- Python 3.8.5, pytest-6.2.4, py-1.10.0, pluggy-0.13.1
rootdir: /home/runner/work/ibis-bigquery/ibis-bigquery
collected 2 items / 4 errors

==================================== ERRORS ====================================
__________________ ERROR collecting tests/unit/test_client.py __________________
tests/unit/test_client.py:4: in <module>
    import ibis_bigquery.client
ibis_bigquery/__init__.py:11: in <module>
    from .client import (BigQueryClient, BigQueryDatabase, BigQueryQuery,
ibis_bigquery/client.py:28: in <module>
    from . import compiler as comp
ibis_bigquery/compiler.py:71: in <module>
    class BigQuerySelectBuilder(comp.SelectBuilder):
E   AttributeError: module 'ibis.backends.base_sql.compiler' has no attribute 'SelectBuilder'
_________________ ERROR collecting tests/unit/test_compiler.py _________________

@gerrymanoim
Copy link
Contributor Author

Sorry about that - I added another try/except so that the CI now passes: gerrymanoim#1.

If I understand the github actions file, github should test against head of ibis master?

Copy link

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jreback
Copy link

jreback commented May 20, 2021

cc @tswast

@gerrymanoim
Copy link
Contributor Author

Sorry there are a few more places that need to be updated - will follow up in a bit.

@gerrymanoim gerrymanoim force-pushed the patch-1 branch 4 times, most recently from 688940d to f2b6cef Compare May 20, 2021 17:33
@jreback
Copy link

jreback commented May 20, 2021

agree this is not pretty. @gerrymanoim can you create an issue to remove this code once ibis-bigquery drops support for ibis < 2.0 (which we should release soon anyhow).

@tswast tswast added the run-ci Code has been reviewed and is deemed safe to run label May 20, 2021
@gerrymanoim
Copy link
Contributor Author

#62

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
run-ci Code has been reviewed and is deemed safe to run
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants