-
Notifications
You must be signed in to change notification settings - Fork 18
BUG: Fix import for new versions of ibis #59
Conversation
@tswast any issues here? |
I'd also like to make sure we maintain compatibility with ibis 1.4.0. At least until there are a few 2.x releases. I see there are some failing test in that build. https://github.com/ibis-project/ibis-bigquery/pull/59/checks?check_run_id=2630857546 e.g.
|
Sorry about that - I added another try/except so that the CI now passes: gerrymanoim#1. If I understand the github actions file, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
cc @tswast |
Sorry there are a few more places that need to be updated - will follow up in a bit. |
688940d
to
f2b6cef
Compare
agree this is not pretty. @gerrymanoim can you create an issue to remove this code once |
The compiler is now at https://github.com/ibis-project/ibis/blob/master/ibis/backends/base_sql/compiler.py