Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to make the
merge()
step in the pipeline more efficient (and also theexecute()
step a bit).The most drastic (and functional) change is that I tried removing the condition-mechanism in
Searcher
. It seems to me like we might as well always "use:skip
"? In that case the searcher will try to avoid skipping anyway and only skip if necessary. The only effect of the condition-mechanism is that if we don't skip whenfind_execute_key()
is called inRunner.merge()
then we're not allowed to skip inRunner.execute()
. I can't actually come up with a situation where this would be the case.Benchmark: I ran
20000.times { pipeline }
with both versions, feeding them touchpad events that I had recorded for a couple of hours. The results show a ~10% speedup.