Use strings.ReplaceAll() rather than strings.Replace() with -1

.pre-commit-config.yaml

@@ -0,0 +1,12 @@
+---
+repos:
+  - repo: https://github.com/jessp01/pre-commit-golang.git
+    rev: v0.5.9
+    hooks:
+      - id: go-fmt
+      - id: go-imports
+      - id: go-vet
+      - id: go-lint
+      - id: go-critic
+      - id: go-ineffassign
+      - id: shellcheck

collector/collector.go

@@ -236,7 +236,7 @@
 	wg.Wait()
 }
 
 func (e *Exporter) scrape(ch chan<- prometheus.Metric) {
 	e.totalScrapes.Inc()
 	var err error
 	defer func(begun time.Time) {
@@ -250,16 +250,16 @@
 
 	if err = e.db.Ping(); err != nil {
 		if strings.Contains(err.Error(), "sql: database is closed") {
 			level.Info(e.logger).Log("Reconnecting to DB")
 			err = e.connect()
 			if err != nil {
 				level.Error(e.logger).Log("Error reconnecting to DB", err)
 			}
 		}
 	}
 
 	if err = e.db.Ping(); err != nil {
 		level.Error(e.logger).Log("Error pinging oracle:", err)
 		e.up.Set(0)
 		return
 	}
@@ -275,7 +275,7 @@
 
 	for _, metric := range e.metricsToScrape.Metric {
 		wg.Add(1)
 		metric := metric //https://golang.org/doc/faq#closures_and_goroutines
 
 		go func() {
 			defer wg.Done()
@@ -301,7 +301,7 @@
 			}
 
 			for column, metricType := range metric.MetricsType {
 				if metricType == "histogram" {
 					_, ok := metric.MetricsBuckets[column]
 					if !ok {
 						level.Error(e.logger).Log("Unable to find MetricsBuckets configuration key for metric. (metric=" + column + ")")
@@ -405,8 +405,8 @@
 }
 
 // generic method for retrieving metrics.
 func (e *Exporter) scrapeGenericValues(db *sql.DB, ch chan<- prometheus.Metric, context string, labels []string,
 	metricsDesc map[string]string, metricsType map[string]string, metricsBuckets map[string]map[string]string, fieldToAppend string, ignoreZeroResult bool, request string) error {
 	metricsCount := 0
 	genericParser := func(row map[string]string) error {
 		// Construct labels value
@@ -420,7 +420,7 @@
 			// If not a float, skip current metric
 			if err != nil {
 				level.Error(e.logger).Log("Unable to convert current value to float (metric=" + metric +
 					",metricHelp=" + metricHelp + ",value=<" + row[metric] + ">)")
 				continue
 			}
 			level.Debug(e.logger).Log("Query result looks like: ", value)
@@ -574,11 +574,11 @@
 }
 
 func cleanName(s string) string {
-	s = strings.Replace(s, " ", "_", -1) // Remove spaces
-	s = strings.Replace(s, "(", "", -1)  // Remove open parenthesis
-	s = strings.Replace(s, ")", "", -1)  // Remove close parenthesis
-	s = strings.Replace(s, "/", "", -1)  // Remove forward slashes
-	s = strings.Replace(s, "*", "", -1)  // Remove asterisks
+	s = strings.ReplaceAll(s, " ", "_") // Remove spaces
+	s = strings.ReplaceAll(s, "(", "")  // Remove open parenthesis
+	s = strings.ReplaceAll(s, ")", "")  // Remove close parenthesis
+	s = strings.ReplaceAll(s, "/", "")  // Remove forward slashes
+	s = strings.ReplaceAll(s, "*", "")  // Remove asterisks
 	s = strings.ToLower(s)
 	return s
 }