Skip to content

Commit

Permalink
Runr + more (#57)
Browse files Browse the repository at this point in the history
* exposing the app title as parameter to be possibly chosen by the user upon launching iSEEindex()

* updting GHA workflow to run with Bioc 3.19 in devel

* version bump

---------

Co-authored-by: Kevin Rue-Albrecht <kevinrue67@gmail.com>
  • Loading branch information
federicomarini and kevinrue authored Feb 22, 2024
1 parent ec8fc0b commit b14d858
Show file tree
Hide file tree
Showing 4 changed files with 26 additions and 9 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/check-bioc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,9 @@ jobs:
fail-fast: false
matrix:
config:
- { os: ubuntu-latest, r: 'devel', bioc: '3.17', cont: "bioconductor/bioconductor_docker:devel", rspm: "https://packagemanager.rstudio.com/cran/__linux__/focal/latest" }
- { os: macOS-latest, r: 'devel', bioc: '3.17'}
- { os: windows-latest, r: 'devel', bioc: '3.17'}
- { os: ubuntu-latest, r: 'devel', bioc: '3.19', cont: "bioconductor/bioconductor_docker:devel", rspm: "https://packagemanager.rstudio.com/cran/__linux__/focal/latest" }
- { os: macOS-latest, r: 'devel', bioc: '3.19'}
- { os: windows-latest, r: 'devel', bioc: '3.19'}
## Check https://github.com/r-lib/actions/tree/master/examples
## for examples using the http-user-agent
env:
Expand Down
7 changes: 5 additions & 2 deletions DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,14 +1,17 @@
Package: iSEEindex
Title: iSEE extension for a landing page to a custom collection of data sets
Version: 1.1.0
Date: 2022-07-06
Version: 1.1.1
Date: 2024-02-21
Authors@R:
c(person("Kevin", "Rue-Albrecht", email = "kevinrue67@gmail.com",
role = c("aut", "cre"),
comment = c(ORCID = "0000-0003-3899-3872")),
person("Thomas", "Sandmann", email = "tomsing1@gmail.com",
role = c("ctb"),
comment = c(ORCID = "0000-0002-6601-8890")),
person("Federico", "Marini", email="marinif@uni-mainz.de",
role="aut",
comment = c(ORCID = '0000-0003-3252-7758')),
person("Denali Therapeutics", role = c("fnd")))
Description: This package provides an interface to any collection of data sets
within a single iSEE web-application. The main functionality of this package is
Expand Down
4 changes: 4 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
# iSEEindex 1.1.1

* Add possibility to customise the title of the app.

# iSEEindex 0.99.13

* Added possibility to inject custom header and footer in landing page.
Expand Down
18 changes: 14 additions & 4 deletions R/iSEEindex.R
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,9 @@
#' @param default.position Character scalar indicating whether the default
#' initial configuration should be added as the `"first"` or `"last"` option
#' in the Shiny `selectizeInput()`.
#' @param app.title Character string to specify the desired title to be displayed
#' in the main window of the dashboard. Defaults to `NULL`, which displays some
#' info on the versions of the `iSEEindex` and `iSEE` packages.
#' @param body.header UI element to display \emph{above} the main landing page body.
#' @param body.footer UI element to display \emph{below} the main landing page body.
#'
Expand Down Expand Up @@ -130,19 +133,26 @@
#' if (interactive()) {
#' shiny::runApp(app, port = 1234)
#' }
iSEEindex <- function(bfc, FUN.datasets, FUN.initial = NULL, default.add = TRUE, default.position = c("first", "last"), body.header = NULL, body.footer = NULL) {
iSEEindex <- function(bfc, FUN.datasets, FUN.initial = NULL, default.add = TRUE, default.position = c("first", "last"), app.title = NULL, body.header = NULL, body.footer = NULL) {
stopifnot(is(bfc, "BiocFileCache"))
if (is.null(FUN.initial)) {
FUN.initial <- function() NULL
}

if (is.null(app.title)) {
app.title <- sprintf("iSEEindex - v%s | powered by iSEE - v%s",
packageVersion("iSEEindex"),
packageVersion("iSEE"))
}

iSEE(
landingPage=.landing_page(bfc, FUN.datasets, FUN.initial, default.add, default.position, body.header, body.footer),
appTitle = sprintf("iSEEindex - v%s",
packageVersion("iSEEindex")
)
appTitle = app.title
)
}



#' Prepare and Launch the Main App.
#'
#' Invokes a function that replaces the landing page by the \pkg{iSEE}
Expand Down

0 comments on commit b14d858

Please sign in to comment.