Performance improvement

iByteABit256 · Feb 14, 2023 · 5ce9bc8 · 5ce9bc8
1 parent 7ff3fbb
commit 5ce9bc8
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 6 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/Cargo.toml b/Cargo.toml
@@ -1,7 +1,8 @@
 [package]
 name = "mrn-generator"
-version = "0.1.0"
+version = "0.2.0"
 edition = "2021"
+authors = ["Pavlos Smith <paulsmith4561+at+gmail.com>"]
 
 # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
 

diff --git a/src/main.rs b/src/main.rs
@@ -28,10 +28,8 @@ fn is_mrn_valid(mrn: &str) -> Option<char> {
 
     let mrn_temp: String = mrn_iter.collect();
 
-    // Powers of 2
-    let multipliers: Vec<u32> = (0..mrn_temp.len()).map(|n| 1 << n).collect();
-
-    let multiplied_sum: u32 = mrn_temp.chars().zip(multipliers).map(|(c,m)| check_character_value(c) as u32 * m).sum();
+    // Multiply each char value with it's power of 2 and sum them
+    let multiplied_sum: u32 = mrn_temp.chars().zip(0..mrn_temp.len()).map(|(c,m)| (check_character_value(c) as u32) << m).sum();
 
     let check_digit: u8 = (multiplied_sum % 11).try_into().unwrap();
     check_remainder_value(check_digit, last_digit)