Skip to content

Commit

Permalink
Initialize fields with zero bytes in wireless module
Browse files Browse the repository at this point in the history
Previously, the fields in the wireless module were declared but not explicitly
initialized upon declaration. As nothing else would do so afterwards, this
could introduce random characters left over in the memory segment into
the fields. This was explicitly observed in the essid-field, but likely
a possibility for other fields as well. Hence, this commit adds explicit
initialization with zero bytes to all fields to ensure proper
termination of all fields.

Fixes #432
  • Loading branch information
cherti committed Oct 9, 2020
1 parent 3451a0d commit afc73e1
Showing 1 changed file with 7 additions and 7 deletions.
14 changes: 7 additions & 7 deletions src/print_wireless_info.c
Original file line number Diff line number Diff line change
Expand Up @@ -554,13 +554,13 @@ void print_wireless_info(yajl_gen json_gen, char *buffer, const char *interface,
}
}

char string_quality[STRING_SIZE];
char string_signal[STRING_SIZE];
char string_noise[STRING_SIZE];
char string_essid[STRING_SIZE];
char string_frequency[STRING_SIZE];
char string_ip[STRING_SIZE];
char string_bitrate[STRING_SIZE];
char string_quality[STRING_SIZE] = {'\0'};
char string_signal[STRING_SIZE] = {'\0'};
char string_noise[STRING_SIZE] = {'\0'};
char string_essid[STRING_SIZE] = {'\0'};
char string_frequency[STRING_SIZE] = {'\0'};
char string_ip[STRING_SIZE] = {'\0'};
char string_bitrate[STRING_SIZE] = {'\0'};

if (info.flags & WIRELESS_INFO_FLAG_HAS_QUALITY) {
if (info.quality_max)
Expand Down

0 comments on commit afc73e1

Please sign in to comment.