Add Condition helper class for more readable code #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bheisig
reviewed
Aug 7, 2023
README.md
Outdated
| ~~~ | ||
|
|
||
| You can use more than one condition and add an operator to them. | ||
| Allowed oprerators are 'AND' and 'OR'. |
bheisig
reviewed
Aug 7, 2023
src/Condition.php
Outdated
| * You should have received a copy of the GNU Affero General Public License | ||
| * along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
| * | ||
| * @author Benjamin Heisig <https://benjamin.heisig.name/> |
There was a problem hiding this comment.
Please remove me as the author 😉
bheisig
reviewed
Aug 7, 2023
src/Condition.php
Outdated
|
|
||
| public $operator; | ||
|
|
||
| public function where($const, $property):self |
There was a problem hiding this comment.
Type declarations would be great, e.g. string $const, $string $property.
bheisig
reviewed
Aug 7, 2023
|
|
||
| use \Exception; | ||
|
|
||
| class ConditionTest extends BaseTest { |
There was a problem hiding this comment.
Some test data would be helpful for the tests
bheisig
reviewed
Aug 7, 2023
bheisig
approved these changes
Aug 14, 2023
|
Please check failed checks on PHP 8.0 and 8.1. |
added 4 commits
August 14, 2023 09:52
with type declarations the characters in this lines exceeds 120. so i have to remove type declarations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Condition helper class for more readable code
Added
File: src/Condition.php
Example:
use Idoit\APIClient\API;
use Idoit\APIClient\CMDBCondition;
use Idoit\APIClient\Condition;
$api = new API([/* … */]);
$condition = new CMDBCondition($api);
$conditions = [
new Condition("C__CATG__ACCOUNTING", "order_no", "=", "ORDER4711"),
new Condition("C__CATG__ACCOUNTING", "order_no", "=", "ORDER4711", Condition::OR),
];
$result = $condition->read($conditions);
File: tests/Idoit/APIClient/ConditionTest.php
Changed
Fiel: README.md
Confirmation
By sending this pull request I accept the following conditions: