Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gis module #213

Merged
merged 2 commits into from
Oct 11, 2024
Merged

Fix gis module #213

merged 2 commits into from
Oct 11, 2024

Conversation

sebastienlanglois
Copy link
Contributor

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • (If applicable) Documentation has been added / updated (for bug fixes / features).
  • (If applicable) Tests have been added.
  • CHANGELOG.rst has been updated (with summary of main changes).
    • Link to issue (:issue:number) and pull request (:pull:number) has been added.

What kind of change does this PR introduce?

GIS module's tests were failing because the Planetary Computer's doesn't allow anonymous access to their blob storage anymore. However, they provide with their python API a way to sign (SAS token) the blobs allowing us to fetch the required files again.

Does this PR introduce a breaking change?

No

Other information:

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Collaborator

@RondeauG RondeauG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci !

@github-actions github-actions bot added the approved Approved for additional tests label Oct 11, 2024
@RondeauG RondeauG changed the base branch from main to simplify_notebooks October 11, 2024 19:17
@sebastienlanglois
Copy link
Contributor Author

Hydrological modeling notebook is failing as well for the same reason. I will add a fix there and the tests should passed after that!

@RondeauG RondeauG changed the base branch from simplify_notebooks to main October 11, 2024 19:18
@RondeauG
Copy link
Collaborator

Ouais j'ai tenté de changer la base de la PR, mais ça n'aide pas. Dans le fond, cette cellule a été retirée dans ma PR.

Tant que tu ajoutes la patch rapidement pour que ça passe. ça sera enlevé tout de suite après anyway.

@sebastienlanglois sebastienlanglois merged commit 28d70e9 into main Oct 11, 2024
17 checks passed
@sebastienlanglois sebastienlanglois deleted the feature/fix-gis branch October 11, 2024 19:43
@sebastienlanglois sebastienlanglois restored the feature/fix-gis branch October 11, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Approved for additional tests bug Something isn't working docs notebooks Run tests against notebooks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants