feat: dns resource #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanneswuerbach
force-pushed
the
dns-resource
branch
from
1f381bb
to
c731572
Compare
johanneswuerbach
force-pushed
the
dns-resource
branch
from
c731572
to
88ebb0c
Compare
mateuszjenek
reviewed
Jan 8, 2024
| required_version = ">= 1.3.0" | ||
| } | ||
|
|
||
| provider "humanitec" {} |
There was a problem hiding this comment.
I'm using here such a configuration:
provider "humanitec" {
host = var.humanitec_host
org_id = var.humanitec_org_id
token = var.humanitec_token
}
But I don't have any opinion about its existence rather than it should be consistent
There was a problem hiding this comment.
For AWS I generally left those values out to reduce the amount of inputs, but we can also keep them.
johanneswuerbach
force-pushed
the
dns-resource
branch
from
88ebb0c
to
e595423
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A
dnsresource using Cloud DNS.