Simplify agent vehicle capture. #1884
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saulfield
approved these changes
Feb 28, 2023
Adaickalavan
approved these changes
Mar 1, 2023
|
This changeset makes me nervous, I stated that we should not have separate cases for vehicle insertion but I do remember how many issues SUMO caused and even swapping over to the local traffic simulation can cause significant disruption. I think this needs serious discussion before merging. |
Gamenot
changed the title
This was referenced Mar 10, 2023
|
This is abandoned for now because we should just find the underlying sumo issue and fix it. |
|
The underlying need is to resolve #619 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.