Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduces Probes by enhancing existing SBWatch #122

Merged
merged 9 commits into from
Aug 20, 2023
Merged

Conversation

JoeAtHPI
Copy link
Collaborator

Currently, SBWatches can be added globally or bound to examples to expressions. They count the number of executions, further display the last evaluated value resulting from the expression.
This MR takes an inspiration from Babylonian S and enhances the locally bound example watches to act like Probes.

  • Instead of the last value, all values from an example run are displayed
  • Example watches reset with every new example evaluation run
  • Modify expressions can be set. This transforms the watched expression values however users see fit, e.g. to display Form objects. Or, imitate assertions as seen in the below screenshot
  • Objects transform themselves into WatchValue morphs instead of using the convert actions to be more compact. They are more flexible with the representation overall

image

@JoeAtHPI JoeAtHPI added enhancement New feature or request Exploriants labels Aug 15, 2023
@JoeAtHPI JoeAtHPI requested a review from tom95 August 15, 2023 09:57
@JoeAtHPI JoeAtHPI self-assigned this Aug 15, 2023
{ #category : #utils }
SBIcon class >> all [

^ (self class selectors select: [:s | s beginsWith: 'icon'])
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be sorted?

@github-actions
Copy link

github-actions bot commented Aug 15, 2023

Pull Request Test Coverage Report for Build 5866909586

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 0.0%

Totals Coverage Status
Change from base Build 5806724678: 0.0%
Covered Lines: 0
Relevant Lines: 0

💛 - Coveralls

@tom95 tom95 merged commit 5c9c15c into master Aug 20, 2023
2 checks passed
@tom95
Copy link
Collaborator

tom95 commented Aug 20, 2023

Great work, thank you!

@JoeAtHPI JoeAtHPI deleted the feature/Probes branch November 24, 2023 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Exploriants
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants